Changes coming from Shim PR and running the original Tests #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Firely.Fhir.Validation/Impl/DatatypeSchema.cs # src/Firely.Fhir.Validation/Impl/ExtensionSchema.cs # src/Firely.Fhir.Validation/Impl/PatternValidator.cs # src/Firely.Fhir.Validation/Impl/ReferencedInstanceValidator.cs # src/Firely.Fhir.Validation/Impl/ResourceSchema.cs # src/Firely.Fhir.Validation/Impl/SchemaReferenceValidator.cs # src/Firely.Fhir.Validation/Impl/SliceValidator.cs # src/Firely.Fhir.Validation/Support/FhirSchemaGroupAnalyzer.cs # test/Firely.Fhir.Validation.Compilation.Tests.Shared/FhirTestCases
ewoutkramer
requested changes
Nov 15, 2023
| /// Returns the slice name of the last slice in the path, or an empty string if there is no slice information. | ||
| /// </summary> | ||
| /// <returns>The slice name of the last slice in the path, or an empty string if there is no slice information.</returns> | ||
| public string GetSliceInfo() |
There was a problem hiding this comment.
I hardly ever find returning empty strings useful, I think most people would expect null if there is no sensible slice info, not an empty string. Or, if you want to make it explicit, call the method TryGetSliceInfo().
ewoutkramer
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.