Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifest tests to newest format #219

Merged
merged 6 commits into from
Dec 11, 2023

Conversation

mmsmits
Copy link
Member

@mmsmits mmsmits commented Dec 11, 2023

No description provided.

@mmsmits mmsmits requested a review from ewoutkramer December 11, 2023 10:56
outcome = engine.Validate(testResource, contextResolver, null);
assertResult(engine.GetExpectedOperationOutcome(testCase), outcome, options);
}
catch (Exception e)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a case when a better idea here? Or was that impossible for some reason?

https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/keywords/when

@mmsmits mmsmits requested a review from ewoutkramer December 11, 2023 12:30
ewoutkramer
ewoutkramer previously approved these changes Dec 11, 2023
@mmsmits mmsmits requested a review from ewoutkramer December 11, 2023 13:30
@mmsmits
Copy link
Member Author

mmsmits commented Dec 11, 2023

Ignored an unused test, to make the pipeline pass

@ewoutkramer ewoutkramer merged commit 9b90369 into develop Dec 11, 2023
2 checks passed
@ewoutkramer ewoutkramer deleted the feature/update-test-cases-to-new-format branch December 11, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants