Make IElementSchemaResolver and ElementSchema public
#237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewoutkramer
requested changes
Dec 19, 2023
| { | ||
| // Schemas representing the root of a FHIR datatype cannot meaningfully be used as a GroupValidatable, | ||
| // so we'll turn this into a normal IValidatable. | ||
| var results = input.Select((i, index) => Validate(i, vc, state.UpdateInstanceLocation(d => d.ToIndex(index)))); | ||
| var results = input.Select((i, index) => ValidateInternal(i, vc, state.UpdateInstanceLocation(d => d.ToIndex(index)))); |
There was a problem hiding this comment.
Here, and in other places, you are now calling ValidateInternal, while conceptually, you should be calling the normal Validate I think. (this will immediately call ValidateInternal in its turn, so there is no technical difference). Validate() is still the main entrance point, dealing with ValidateInternal should I think only be necessary for derived classes - we should make it protected.
| @@ -116,6 +119,7 @@ virtual Firely.Fhir.Validation.Canonical.<Clone>$() -> Firely.Fhir.Validation.Ca | |||
| virtual Firely.Fhir.Validation.Canonical.EqualityContract.get -> System.Type! | |||
| virtual Firely.Fhir.Validation.Canonical.Equals(Firely.Fhir.Validation.Canonical? other) -> bool | |||
| virtual Firely.Fhir.Validation.Canonical.PrintMembers(System.Text.StringBuilder! builder) -> bool | |||
| virtual Firely.Fhir.Validation.ElementSchema.ToJson() -> Newtonsoft.Json.Linq.JToken! | |||
There was a problem hiding this comment.
This is probably the same issue as Validate. Though to have a ToJsonInternal seems overkill here. So just make this public indeed....
ewoutkramer
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Firely Validator we use a
CarElementSchemaResolver, which implementsIElementSchemaResolver. This was first internal and in this PR this has been made public.