Fix validate code to comply to external term services #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewoutkramer
requested changes
Nov 25, 2024
| Coding cd => vcp.WithCoding(cd), | ||
| CodeableConcept cc => vcp.WithCodeableConcept(cc), | ||
| _ => throw Error.InvalidOperation($"Parsed bindable was of unexpected instance type '{bindable.TypeName}'.") | ||
| }; | ||
| }; ; |
mmsmits
commented
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates and refactorings to the Firely FHIR validation library and its tests. The most significant changes include updating the Firely SDK version, removing the
Contextproperty from theBindingValidatorclass, and modifying test cases to reflect these changes.SDK Version Update:
5.10.3to5.11.1infirely-validator-api-tests.propsandfirely-validator-api.propsfiles. [1] [2]BindingValidator Refactoring:
Contextproperty and parameter from theBindingValidatorclass and its constructor. [1] [2] [3]BindingBuilder.csto remove theContextargument fromBindingValidatorinstantiation.Test Cases Update:
Contextparameter fromBindingValidatorinstantiation inSlicingSchemaConverterTests.csandBindingValidatorTests.cs. [1] [2] [3] [4] [5]Miscellaneous:
fhirpkg.lock.jsonfile with a new timestamp.FhirTestCases.