Skip to content

Commit

Permalink
tools: set eslint comma-spacing to 'warn'
Browse files Browse the repository at this point in the history
Certain cases with comments inside arrays or object literals fail to
pass eslint's comma-spacing rule. This change sets the comma-spacing
rule to the 'warn' level.

Once eslint/eslint#2408 is resolved and
released, this rule should be set back to 'error' level.

PR-URL: nodejs#1672
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
  • Loading branch information
silverwind authored and Fishrock123 committed May 19, 2015
1 parent 82a5dab commit ecb2436
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ rules:
- 2
- 2
## add space after comma
comma-spacing: 2
## set to 'warn' because of https://github.com/eslint/eslint/issues/2408
comma-spacing: 1
## put semi-colon
semi: 2
## require spaces operator like var sum = 1 + 1;
Expand All @@ -55,21 +56,20 @@ rules:
## require parens for Constructor
new-parens: 2
## max 80 length
max-len:
max-len:
- 2
- 80
- 2


# Strict Mode
# list: https://github.com/eslint/eslint/tree/master/docs/rules#strict-mode
## 'use strict' on top
strict:
strict:
- 2
- "global"

# Global scoped method and vars
globals:
globals:
DTRACE_HTTP_CLIENT_REQUEST: true
LTTNG_HTTP_CLIENT_REQUEST: true
COUNTER_HTTP_CLIENT_REQUEST: true
Expand All @@ -88,4 +88,3 @@ globals:
DTRACE_NET_SERVER_CONNECTION: true
LTTNG_NET_SERVER_CONNECTION: true
COUNTER_NET_SERVER_CONNECTION: true

0 comments on commit ecb2436

Please sign in to comment.