Testing/extend component unit tests #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
library
…ject's dependencies, not devDependencies" see https://stackoverflow.com/a/44939592
react-testing-library is not able to detect that the ancestor element of the element containing the text has overflow=hidden applied. Cypress is way smarter here. https://github.com/testing-library/jest-dom/#tobevisible https://docs.cypress.io/guides/core-concepts/interacting-with-elements.html#Additionally-an-element-is-considered-hidden-if
This reverts commit ec9b9c4
…suggestion is being displayed
…ponent_unit_tests # Conflicts: # package-lock.json # package.json
…ponent_unit_tests # Conflicts: # package-lock.json
The problem can be solved by importing node-fetch here. Even better would be to use `ky-universal` but that would require further refactoring.
|
Running the tests takes 15s for me. This seems quite slow doesn't it? @s-pic Do you know what takes so much time? |
…sts' into testing/extend_component_unit_tests
|
When I ran the tests it took 6 seconds. Anyhow I lowered the configured |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a first unit-test for complex React-Component, the
<AutoCompleteGeocoder/>.This proves that the chosen libaries (react-testing-library) and msw work well for us.
Fixes #FixMyBerlin/fixmy.platform#341
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Ran new unit tests
Checklist: