Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent redirection to x.com from fxtwitter #822

Closed
elijahr2411 opened this issue May 29, 2024 · 3 comments
Closed

Prevent redirection to x.com from fxtwitter #822

elijahr2411 opened this issue May 29, 2024 · 3 comments
Assignees
Labels
embeds This issue affects embeds on one or more platforms enhancement New feature or request wontfix This will not be worked on

Comments

@elijahr2411
Copy link

When someone clicks an fxtwitter link, ?mx=1 should be added to the twitter URL it redirects to, which prevents the redirect to x.com

Example:

twitter.com/someone/status/1234567890 -> might redirect to x.com
twitter.com/someone/status/1234567890?mx=1 -> Will stay on twitter.com, at least for now

@joshcangit
Copy link

joshcangit commented May 30, 2024

If you didn't know, Twitter has already migrated, albeit not completely, to x.com.

https://twitter.com/elonmusk/status/1791351500217754008?mx=1

So, using ?mx=1 works for now but who knows if it will remain this way?
Best to just wait and see.

@dangeredwolf dangeredwolf added enhancement New feature or request embeds This issue affects embeds on one or more platforms labels Jun 17, 2024
@dangeredwolf dangeredwolf self-assigned this Jul 11, 2024
dangeredwolf added a commit that referenced this issue Aug 4, 2024
@AncientAzem
Copy link

Just wanted to make note on here that while the adding the ?mx=1 param to the redirect does keep it on twitter.com site, a user's login session does not work unless they are redirected onto the x.com version of the site. So if someone opened an fx link with the intent to interact with the post they now need to reload the page to do so.

dangeredwolf added a commit that referenced this issue Aug 6, 2024
@dangeredwolf
Copy link
Member

Yeah, good point @AncientAzem. At the moment I'm leaning towards just not doing anything because either you can use an extension to prevent redirection to x.com, or for people already using x.com it works like normal as-is.

@dangeredwolf dangeredwolf closed this as not planned Won't fix, can't repro, duplicate, stale Aug 6, 2024
@dangeredwolf dangeredwolf added the wontfix This will not be worked on label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embeds This issue affects embeds on one or more platforms enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants