Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set isRoboTest to true for robo tests #2535

Merged
merged 3 commits into from
Oct 28, 2024
Merged

fix: set isRoboTest to true for robo tests #2535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f065fd7
fix: set isRoboTest to true for robo tests
Oct 23, 2024
35067a3
test: add test to verify property updates for Robo Test matrices
SelaseKay Oct 25, 2024
e1b101f
test: add initial assertion to verify isRoboTest is false by default
SelaseKay Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test_runner/src/main/kotlin/ftl/domain/testmatrix/UpdateTestMatrix.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ private fun TestMatrix.Data.updateProperties(newMatrix: TestMatrix.Data) = copy(
testFileName = newMatrix.testFileName,
isCompleted = MatrixState.completed(state) &&
newMatrix.testExecutions.all { MatrixState.completed(it.state) },
testExecutions = newMatrix.testExecutions
testExecutions = newMatrix.testExecutions,
isRoboTest = newMatrix.isRoboTest,
)

private fun TestMatrix.Data.updateBillableMinutes(billableMinutes: TestMatrix.BillableMinutes) = copy(
Expand Down
24 changes: 24 additions & 0 deletions test_runner/src/test/kotlin/ftl/api/TestMatrixTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,30 @@ class TestMatrixTest {
val updatedMatrix = testMatrix.updateWithMatrix(ftlTestMatrix.toApiModel())
assertEquals("N/A", updatedMatrix.appFileName)
}

@Test
fun `isRoboTest property should update to true for Robo Test matrices`() {
val testExecutions = listOf(
createStepExecution(1, "shamu"),
createStepExecution(1, "NexusLowRes")
)

val matrixId = "123"
val ftlTestMatrix = ftlTestMatrix()
ftlTestMatrix.testMatrixId = matrixId
ftlTestMatrix.state = PENDING
ftlTestMatrix.resultStorage = createResultsStorage()
ftlTestMatrix.testExecutions = testExecutions

SelaseKay marked this conversation as resolved.
Show resolved Hide resolved
var testMatrix = ftlTestMatrix.toApiModel()
assert(!testMatrix.isRoboTest)

val newTestMatrix = ftlTestMatrix.toApiModel().copy(isRoboTest = true)
testMatrix = testMatrix.copy(state = FINISHED)
testMatrix = testMatrix.updateWithMatrix(newTestMatrix)

assert(testMatrix.isRoboTest) { "isRoboTest was not updated" }
}
}

private inline fun ref(path: () -> String) = FileReference().apply { gcsPath = path() }
Loading