allow redis v5 #28
Merged
allow redis v5 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Look like Python 3.7 would need to be removed from support. |
|
Up to you on how to proceed here, but it seems like only the Edit: looks like the referenced PR was never merged. |
|
look good to me anyway! Thanks |
|
apologies for not including this in the PR, but does the version need to be bumped to republish PyPI? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all, I'd like to see if we can support
redisv5 in the official repo.redisis now onv5.0.9anddramatiqsupportsredisversions <6.0 .pytestpasses, andtoxseems to produce no new errors. I have also tested this in my own application which usesredis==5.0.3and the functionality works as intended.