Support ExtendedCpuGpuSplit pattern, and more #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Profiling results from the Nsight Systems reports that a huge amount (~90%) of timing is consumed by `cuMemHostAlloc`, when a slice of array (e.g., `Uin(:, :, :, :, n)`) is passed to the SFR's argument. This commit avoids `cuMemHostAlloc` in the profiling results by introducing "wrapper" subroutines for each SFRs. However, the overall performance results remain the same, even though the Nsight Systems doesn't report `cuMemHostAlloc`. Perhaps it was an incorrect profiling results, but I push this commit to investigate this further.
|
In the meantime, support for the
|
|
Can we revert the cherry picking and merge this PR instead? The subroutine wrappers should have no or minimal impacts on the performance, and they relieve the I prefer to maintain the |
kweide
added a commit
that referenced
this pull request
Nov 27, 2024
Those cherry-pick commits should not have been done on the main branch. The shell command I am using to restore the main branch to the desired state is git restore --staged --worktree --source=1f5a60a88315ca854516b254d5796b8e81d8d3f6 :/ A proper merge commit, merging the GitHub PR #1, is to follow soon. The changes undone here will then be applied once more, together with others.
kweide
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following:
pushTilesupport for theExtendedCpuGpuSplitpattern.