Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to GenericTypeCollection equality to not consider generic type… #34

Merged
merged 1 commit into from
May 9, 2017
Merged

Change to GenericTypeCollection equality to not consider generic type… #34

merged 1 commit into from
May 9, 2017
+34 −1

Conversation

richkeenan
Copy link
Collaborator

… name as it was causing a bug when overriding generic types. Fixes #33

@richkeenan
Change to GenericTypeCollection equality to not consider generic type…
173ccf6 
… name as it was causing a bug when overriding generic types. Fixes #33
@richkeenan
Copy link
Collaborator Author

Unable to use getType().getTypeName() as that's a Java 8 feature. Given that a GenericType contains a SpecimenType (not the more generic Type) I don't see a need to check the name anyway.

@richkeenan richkeenan merged commit 4306daa into master May 9, 2017
@richkeenan richkeenan deleted the issue33 branch May 9, 2017 14:12
richkeenan added a commit to richkeenan/jfixture that referenced this pull request May 11, 2020
@richkeenan
Change to GenericTypeCollection equality to not consider generic type…
43bc1e5 
… name as it was causing a bug when overriding generic types. Fixes FlexTradeUKLtd#33 (FlexTradeUKLtd#34)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@richkeenan