fix(machine learning): fix algorithms parameters reset on algo select…

… change
FlorentinTh · May 15, 2021 · 3e620fb · 3e620fb
1 parent db2fb91
commit 3e620fb
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 10 deletions.
diff --git a/src/components/admin/data/file-management/file-content/file-list.hbs b/src/components/admin/data/file-management/file-content/file-list.hbs
@@ -20,10 +20,10 @@
   <div class="right">
     <div class="actions">
       <p class="action">
-        {{#[utils/compare] ../fileType '===' 'models'}}
-        <button class="btn-disabled" id="download" disabled>Download</button>
-        {{else}}
+        {{#[utils/compare] ../fileType '!==' 'models'}}
         <button id="download">Download</button>
+        {{else}}
+        <button class="btn-disabled" id="download" disabled>Download</button>
         {{/[utils/compare]}}
       </p>
       <p class="action">

diff --git a/src/components/admin/home/pipelines/machine-learning/tasks/learning/Learning.js b/src/components/admin/home/pipelines/machine-learning/tasks/learning/Learning.js
@@ -175,6 +175,7 @@ class Learning extends Task {
 
     if (!(confParamsStore === undefined)) {
       Store.remove('conf-params');
+      this.removeAlgoParams();
     }
 
     const select = event.target;
@@ -262,20 +263,24 @@ class Learning extends Task {
     }
   }
 
-  removeAlgoData() {
-    const storedValue = sessionStorage.getItem('algorithm-name');
-    if (!(storedValue === undefined)) {
-      sessionStorage.removeItem('algorithm-name');
-      algoSelect.options[0].selected = true;
-    }
-
+  removeAlgoParams() {
     const JSONValues = JSON.parse(JSON.stringify(sessionStorage));
     // eslint-disable-next-line array-callback-return
     Object.keys(JSONValues).filter(key => {
       if (/^algo-param-/.test(key)) {
         sessionStorage.removeItem(key);
       }
     });
+  }
+
+  removeAlgoData() {
+    const storedValue = sessionStorage.getItem('algorithm-name');
+    if (!(storedValue === undefined)) {
+      sessionStorage.removeItem('algorithm-name');
+      algoSelect.options[0].selected = true;
+    }
+
+    this.removeAlgoParams();
 
     const paramsContainer = this.context.querySelector('.params-container');