-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Device Editor resource caching #3414
Comments
Reported as a solution to https://flowforgeworkspace.slack.com/archives/C032Q63FGG1/p1731506732697229 where one of our customers are experiencing long first-load times on particular machines via the proxy connection to the Editor |
We could populate the Docker containers with a starter cache of versions. Also this only works with device agent 3.0.x (not 3.0.0 as it depends on FlowFuse/device-agent#327) My current thought is that we should add create a list of NR versions and pre-populate the Docker containers with them. This will cover the main use case of FFC and FF Dedicated (the 2 places with the most devices). This will need to be done in 2 places
(I would like to find a way to make these the same file again, but that is a different problem) Downsides to this it will increase the size of the Docker containers by about 30mb per Node-RED version. Current list of NR versions to include I think for the best coverage:
I don't think we need to add automatic install of new NR versions for the following 2 reasons
|
@hardillb can I get a status check please? |
Basically need feedback on last update And of course list of NR versions will need fix release planned for this week added. /cc @knolleary |
Forge app code is up for review Outstanding action is update to helm docker build and CI docker container build. |
Verified on Staging |
Description
This is a quicker rewrite after GitHub discarded what I wrote on submission of the New Issue form...
We should cache the well-defined static files of Node-RED in the Device editor proxy.
This will mean the first device to enabled the editor (for a given Node-RED version) after a restart will pay the (existing) penalty of retrieving the files from the device for the cache, but every subsequent request will hit the cache.
We could, in the future, consider bundling these files in the platform - although that has some complication around how to update the bundled files for new versions of Node-RED.
The approach proposed above should be a pretty quick solution to improve the initial load time of the device editor and also make us more tolerant of slower networks.
Required By
The text was updated successfully, but these errors were encountered: