Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default tab in the team library isn't the library #3871

Closed
ZJvandeWeg opened this issue May 16, 2024 · 6 comments
Closed

Default tab in the team library isn't the library #3871

ZJvandeWeg opened this issue May 16, 2024 · 6 comments
Assignees
Labels
area:frontend For any issues that require work in the frontend/UI size:XS - 1 Sizing estimation point
Milestone

Comments

@ZJvandeWeg
Copy link
Member

Current Behavior

When a user clicks on library they see:

Screenshot 2024-05-16 at 14 12 40

Where I believe they should be seeing:
Screenshot 2024-05-16 at 14 13 08

With the slight exception that the library should be the first tab from the left too.

Expected Behavior

No response

Steps To Reproduce

No response

Environment

  • FlowFuse version:
  • Node.js version:
  • npm version:
  • Platform/OS:
  • Browser:

Have you provided an initial effort estimate for this issue?

I can not provide an initial effort estimate

@ZJvandeWeg ZJvandeWeg added bug Something isn't working needs-triage Needs looking at to decide what to do labels May 16, 2024
@ZJvandeWeg
Copy link
Member Author

cc @joepavitt @cstns

@ZJvandeWeg ZJvandeWeg added this to the 2.5 milestone May 16, 2024
@ZJvandeWeg ZJvandeWeg added the size:XS - 1 Sizing estimation point label May 16, 2024
@cstns
Copy link
Contributor

cstns commented May 16, 2024

I followed the design in #3598 (comment) when implementing #3729 which led me to believe that since the blueprints are the first option they should be opened by default

@joepavitt
Copy link
Contributor

Yep - entirely on me to have it the wrong way round in the design. I agree here that there is merit in switching the tabs and having the Team Library tab be the default

@joepavitt joepavitt added area:frontend For any issues that require work in the frontend/UI and removed bug Something isn't working needs-triage Needs looking at to decide what to do labels May 16, 2024
@joepavitt joepavitt moved this to Todo in 🛠 Development May 17, 2024
@friyad
Copy link
Contributor

friyad commented May 20, 2024

Hello @ZJvandeWeg,
I want to work on this issue. Could you please assign this issue to me?

Though I have already completed the task.

Screenshot of work

@joepavitt
Copy link
Contributor

Thanks for working on this @friyad - feel free to open a PR when it's ready

@joepavitt joepavitt moved this from Todo to In Progress in 🛠 Development May 21, 2024
friyad added a commit to friyad/flowfuse that referenced this issue May 21, 2024
When a user clicks on Library they see Blueprints route as default. But it should be Team Library route. That was the problem and by this commit this issue has been solved
@friyad
Copy link
Contributor

friyad commented May 21, 2024

Hell @ZJvandeWeg & @joepavitt,
I opened a PR. It would be appreciated if you could check it. PR id: #3897

@joepavitt joepavitt moved this to Scheduled in ☁️ Product Planning May 22, 2024
cstns added a commit that referenced this issue May 24, 2024
Default tab fixed for Library page - issue #3871
@cstns cstns mentioned this issue May 27, 2024
10 tasks
@knolleary knolleary moved this from Scheduled to Closed / Done in ☁️ Product Planning May 28, 2024
@knolleary knolleary moved this from In Progress to Done in 🛠 Development May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend For any issues that require work in the frontend/UI size:XS - 1 Sizing estimation point
Projects
Archived in project
Status: Done
Development

No branches or pull requests

5 participants