Auto-snapshot out of sync with current flows

[knolleary]

Current Behavior

Reported by customer on FFC - the latest auto-snapshot of their instance is different to the current deployed flows. Not sure how that is possible - nor if it can be recreated. I did look at their snapshot/flows and confirmed the difference.

Worth noting the snapshot was 2.4Mb in size - in case there's a timing issue here.

Expected Behavior

Auto-snapshot to reliably be the latest deployed flows.

Steps To Reproduce

Unknown

Environment

• FlowFuse version:
• Node.js version:
• npm version:
• Platform/OS:
• Browser:

Have you provided an initial effort estimate for this issue?

I can not provide an initial effort estimate

[knolleary]

This may be related to the async update of flows and credentials. The snapshot contains the latest flows, but not credentials - not proven.

[atorich-th]

I am the

customer on FFC

This may be related to the async update of flows and credentials. The snapshot contains the latest flows, but not credentials - not proven.

Not confirmed. The last auto snapshot have the previous version of flows and credentials both. Just checked it.

[knolleary]

I have confirmed this is a timing issue.

The auto-snapshot is triggered when the Node-RED instance logs the flows.set audit event.

Within the Node-RED codebase, the audit event is logged immediately before the flows/credentials are passed to the storage layer to be saved.

If the flows/credentials are sufficiently large, a timing window opens up where the auto-snapshot is created before Node-RED has finished saving the flows/credentials.

We need to move the trigger for auto-snapshot out of the audit-log handler and over to the storage api.