Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user to flow storage #287

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Add user to flow storage #287

merged 2 commits into from
Dec 5, 2024

Conversation

hardillb
Copy link
Contributor

part of FlowFuse/flowfuse#4413

Description

Passes the user who is doing the deploy to FlowFuse Storage backend

Related Issue(s)

FlowFuse/flowfuse#4413

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl
Copy link
Contributor

Ben, as mentioned in the parent issue comment, PR #4530 has been raised. That PR may supersede this PR but I am not 100% certain this isn't worth doing also?

@Steve-Mcl
Copy link
Contributor

Ben, I know this is no longer an absolute requirement for the original issue, but I can see a future where this would be useful.

Should we merge or put it in draft for the time being?

@hardillb
Copy link
Contributor Author

Let's put it in draft until we decide if we need it

@hardillb hardillb marked this pull request as draft September 25, 2024 09:42
@Steve-Mcl Steve-Mcl removed their request for review October 4, 2024 08:14
@knolleary
Copy link
Member

As this may become useful again for FlowFuse/flowfuse#4791 - so am going to pull out of draft and get merged. Even if we don't make use of it immediately, given it requires stack updates for instances to pickup, the sooner we have it out there, the sooner we can rely on it.

@knolleary knolleary marked this pull request as ready for review December 5, 2024 14:39
Copy link
Member

@knolleary knolleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly this is the only function on the API that receives user info from Node-RED - otherwise we'd want to add this header to them all for future proofing.

Have tested locally and it does the job.

@knolleary knolleary merged commit 72b8105 into main Dec 5, 2024
5 checks passed
@knolleary knolleary deleted the auto-snapshot-user branch December 5, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants