Set disableRequestedAuthnContext in SAML strategy #3519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3519 +/- ##
=======================================
Coverage 41.95% 41.95%
=======================================
Files 617 617
Lines 23548 23548
Branches 5706 5706
=======================================
Hits 9880 9880
Misses 13668 13668
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hardillb
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents our SAML implementation from sending the optional
RequestedAuthnContextvalue in the SAML request. This can cause issues when using Entra - as documented here: node-saml/passport-saml#226I have not been able to reproduce the original issue (#3518) as the precise Entra configuration is not clear. However, from the information provided by MS in that issue, and the linked issue above, I'm confident this will address the problem.
I've gone for disabling it be default. We may need to make it configurable in the future, but for now, I have tested against Okta, OneLogin and Entra with success.