Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage around user invites #3721

Merged
merged 7 commits into from
Apr 15, 2024
Merged

Conversation

knolleary
Copy link
Member

Fixes https://github.com/FlowFuse/security/issues/86

This improves our test coverage and validation around user invites.

@knolleary knolleary requested a review from hardillb April 15, 2024 15:11
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 41.99%. Comparing base (d4a423a) to head (0efeed7).

Files Patch % Lines
forge/db/controllers/Invitation.js 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3721      +/-   ##
==========================================
+ Coverage   41.86%   41.99%   +0.12%     
==========================================
  Files         631      631              
  Lines       24541    24546       +5     
  Branches     5998     6002       +4     
==========================================
+ Hits        10274    10308      +34     
+ Misses      14267    14238      -29     
Flag Coverage Δ
backend 79.12% <93.33%> (+0.24%) ⬆️
frontend 1.90% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knolleary
Copy link
Member Author

Broken tests - will investigate

@hardillb hardillb self-requested a review April 15, 2024 15:32
@knolleary
Copy link
Member Author

Tests should be fixed now

@hardillb hardillb merged commit 9464489 into main Apr 15, 2024
10 checks passed
@hardillb hardillb deleted the team-invite-test-coverage branch April 15, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants