Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new full width layout #3740

Merged
merged 7 commits into from
Apr 18, 2024
Merged

Add a new full width layout #3740

merged 7 commits into from
Apr 18, 2024

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Apr 16, 2024

Description

  • Added a new Plain layout that does not include navigation menus.
  • Altered the way that the layout is selected on page load, the layout selection is determined based on route 'layout' attribute and in absence will default to the Platform layout.
  • Altered the log polling functionality which was based on route paths to again use a meta attribute 'shouldPoll' adding the possibility to fine tune the routes that use it.
  • Extracts Alerts logic into a standalone mixin

Related Issue(s)

required in #3656

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@cstns cstns self-assigned this Apr 16, 2024
@cstns cstns added area:frontend For any issues that require work in the frontend/UI size:XS - 1 Sizing estimation point labels Apr 16, 2024
@cstns
Copy link
Contributor Author

cstns commented Apr 16, 2024

The existing layout functionality should not be impacted as no pages currently use the plain layout. This being said, the setupApp should also be tested.
In order to check the new plain layout, one could add the 'layout: "plain"' meta attribute to a page (one that preferably does not have teleport components) and check that the page loads without any menus. Additionally, alerts and modals should be tested that they work on the new layout.

@cstns cstns requested a review from joepavitt April 16, 2024 11:37
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 48 lines in your changes are missing coverage. Please review.

Project coverage is 42.01%. Comparing base (6b92d2d) to head (3888e69).
Report is 5 commits behind head on main.

Files Patch % Lines
frontend/src/mixins/Dialog.js 0.00% 20 Missing ⚠️
frontend/src/mixins/Alerts.js 0.00% 10 Missing ⚠️
frontend/src/App.vue 0.00% 7 Missing ⚠️
frontend/src/layouts/Plain.vue 0.00% 7 Missing ⚠️
...end/src/pages/instance/components/InstanceLogs.vue 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3740      +/-   ##
==========================================
- Coverage   42.04%   42.01%   -0.04%     
==========================================
  Files         631      634       +3     
  Lines       24601    24620      +19     
  Branches     6019     6030      +11     
==========================================
  Hits        10344    10344              
- Misses      14257    14276      +19     
Flag Coverage Δ
backend 79.14% <ø> (ø)
frontend 1.89% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joepavitt
Copy link
Contributor

Approved - just running tests against the new main changes being merged, once they pass, you're good to go

@cstns cstns merged commit accf764 into main Apr 18, 2024
9 of 10 checks passed
@cstns cstns deleted the add-a-new-full-width-layout branch April 18, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend For any issues that require work in the frontend/UI size:XS - 1 Sizing estimation point
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants