Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make blueprints accessible outside of "Create Instance" menu #3752

Merged
merged 40 commits into from
May 1, 2024

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Apr 19, 2024

Description

Adds the ability to visualize existing blueprints and use them when creating instances.

Related Issue(s)

closes #3729

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@cstns cstns self-assigned this Apr 19, 2024
@cstns cstns added the area:frontend For any issues that require work in the frontend/UI label Apr 19, 2024
@cstns cstns requested a review from joepavitt April 19, 2024 16:56
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 1.42857% with 69 lines in your changes are missing coverage. Please review.

Project coverage is 41.71%. Comparing base (8c36a97) to head (27870af).
Report is 2 commits behind head on main.

Files Patch % Lines
frontend/src/pages/team/Library/Blueprints.vue 0.00% 25 Missing ⚠️
frontend/src/pages/team/Library/TeamLibrary.vue 0.00% 19 Missing ⚠️
frontend/src/mixins/Features.js 0.00% 7 Missing ⚠️
frontend/src/pages/team/Library/index.vue 0.00% 5 Missing ⚠️
...end/src/pages/instance/components/InstanceForm.vue 0.00% 4 Missing ⚠️
frontend/src/pages/team/createInstance.vue 0.00% 4 Missing ⚠️
frontend/src/pages/team/routes.js 0.00% 2 Missing ⚠️
...c/pages/instance/Blueprints/BlueprintSelection.vue 0.00% 1 Missing ⚠️
frontend/src/store/account.js 0.00% 1 Missing ⚠️
...rontend/src/ui-components/components/tabs/Tabs.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3752      +/-   ##
==========================================
- Coverage   41.76%   41.71%   -0.06%     
==========================================
  Files         647      650       +3     
  Lines       24768    24801      +33     
  Branches     6076     6084       +8     
==========================================
  Hits        10345    10345              
- Misses      14423    14456      +33     
Flag Coverage Δ
backend 79.14% <ø> (ø)
frontend 1.88% <1.42%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joepavitt joepavitt changed the title 3729 enhance blueprint accessibility Make blueprints accessible outside of "Create Instance" menu Apr 23, 2024
cstns added 3 commits April 26, 2024 16:34
…t-accessibility

# Conflicts:
#	frontend/src/pages/team/Library/TeamLibrary.vue
…t-accessibility

# Conflicts:
#	frontend/src/pages/instance/Editor/index.vue
@joepavitt
Copy link
Contributor

Have hit a blocker on this, when trying to start an instance that was created via the new library > blueprint workflow, instances crash to to false dependencies.

Here on our blueprint, we have defined no modules:

Screenshot 2024-05-01 at 13 40 34

Note it's trying to add the blueprint's piece as a instance dependency:

Screenshot 2024-05-01 at 13 38 24

@joepavitt
Copy link
Contributor

Turns out the above was my problem, the blueprints config just needs to be an empty object {}, not with modules: [] in it

@joepavitt joepavitt merged commit b7e13e5 into main May 1, 2024
10 of 11 checks passed
@joepavitt joepavitt deleted the 3729-enhance-blueprint-accessibility branch May 1, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend For any issues that require work in the frontend/UI deploy:pr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancing Blueprint Accessibility (First Iteration)
2 participants