-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow user setting node red version setting for application assigned devices #3766
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3766 +/- ##
==========================================
- Coverage 79.15% 79.14% -0.02%
==========================================
Files 278 278
Lines 12494 12501 +7
Branches 2771 2773 +2
==========================================
+ Hits 9890 9894 +4
- Misses 2604 2607 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Arrrrgggghhhh unrelated e2e test still failing
Tests run cleanly in local env with cypress open. will try full run without cypress open locally - perhaps something related to other tests is causing order of elements to be different? UPDATE: Fails with updated test since ordering of the devices differs depending on running full suite vs running single test. Locally, I have reverted the test modification to original which was failing like this:
and ran the full suite and it works (arrrgggghhh No. 2!) Will push original test momentarily. |
…wFuse/flowfuse into 2802-device-node-red-version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this has some dependency on the agent version, I think we should inform the user what behaviour they will get based on the known agent version.
- older agents: NR version will only get applied when a new snapshot is deployed
- new agents: NR version will get updated after settings saved (and/or new snapshot is deployed).
Exactly what version number to test for depends on us releasing the Device Agent - which we can do first
@Steve-Mcl Add feedback when user applies a NR version to the device - so that they know when/how the set version will be applied (based on the agent version) |
Since Agent is currently v2.4.0 and #254 has been merged, i can use a semvar <= 2.4.0 to indicate the alternative meeans of applying the NR version update. Here is a demo - lay out was discussed with @joepavitt Footnotes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved - with just one small rewording suggestion
Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
Only pause is now that this setting doesn't get applied if the device is in developer mode. Lets move forward with this for now, but I think we need a step back look at developer mode and how we communicate what does/doesn't happen whilst in that state and how we can improve things. For example, we don't let a pipeline stage get triggered from a developer-mode device.... which feels odd if its your development device you want to snapshot and deploy... but I digress and will follow up separately. |
NOTE: Part 1 of 2. Only merge when both this and the device agent counterpart are both approved.
Description
As per Approach in issue discussion:
further details and considerations are written in the linked issue
Related Issue(s)
Closes #2802
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
backport
labelarea:migration
label