Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitise output of snapshot /export API #3797

Merged
merged 6 commits into from
May 1, 2024
Merged

Conversation

Steve-Mcl
Copy link
Contributor

Description

Enforce sanitised output by implementing view ProjectSnapshot.snapshotExport and applying it to the API.

NOTE: modules was removed from the schema as it is never populated (modules is a sub property of settings)

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 41.71%. Comparing base (b7e13e5) to head (1b5958c).

Files Patch % Lines
forge/db/views/ProjectSnapshot.js 75.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3797   +/-   ##
=======================================
  Coverage   41.71%   41.71%           
=======================================
  Files         650      650           
  Lines       24801    24809    +8     
  Branches     6084     6091    +7     
=======================================
+ Hits        10345    10350    +5     
- Misses      14456    14459    +3     
Flag Coverage Δ
backend 79.14% <90.90%> (-0.01%) ⬇️
frontend 1.88% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knolleary knolleary merged commit 426379c into main May 1, 2024
11 checks passed
@knolleary knolleary deleted the fix-snapshot-export branch May 1, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants