Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redirect for /project/xyz to /instance/xyz #3808

Merged
merged 2 commits into from
May 1, 2024

Conversation

knolleary
Copy link
Member

@knolleary knolleary commented May 1, 2024

Fixes #3799

The nr-launcher includes a link to the FF application in the format /project/:id. At some point, that has started to 404. This adds a redirect in place so it gets to the right place.

I'll raise a separate PR on nr-launcher to use the right url to start with. already done via FlowFuse/nr-launcher#229

@knolleary knolleary marked this pull request as ready for review May 1, 2024 13:35
@knolleary knolleary requested a review from joepavitt May 1, 2024 13:35
Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 41.70%. Comparing base (426379c) to head (cf372a0).
Report is 3 commits behind head on main.

❗ Current head cf372a0 differs from pull request most recent head 165d800. Consider uploading reports for the commit 165d800 to get more accurate results

Files Patch % Lines
frontend/src/pages/instance/routes.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3808      +/-   ##
==========================================
- Coverage   41.71%   41.70%   -0.02%     
==========================================
  Files         650      650              
  Lines       24809    24803       -6     
  Branches     6091     6084       -7     
==========================================
- Hits        10350    10345       -5     
+ Misses      14459    14458       -1     
Flag Coverage Δ
backend 79.14% <ø> (+<0.01%) ⬆️
frontend 1.88% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joepavitt joepavitt merged commit 2182004 into main May 1, 2024
10 checks passed
@joepavitt joepavitt deleted the 3799-fix-project-redirect branch May 1, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirect from Node-RED menu back to FF Application 404s
2 participants