Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the immersive editor dashboard button #3837

Merged

Conversation

cstns
Copy link
Contributor

@cstns cstns commented May 8, 2024

Description

Fixes the immersive editor's dashboard button by disabling it when the instance is not available/

Related Issue(s)

closes #3789

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@cstns cstns requested a review from joepavitt May 8, 2024 08:31
@cstns cstns self-assigned this May 8, 2024
@cstns cstns added area:frontend For any issues that require work in the frontend/UI and removed deploy:pr labels May 8, 2024
Copy link
Contributor

@joepavitt joepavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes look good - approved subject to the CI/CD pipeline all passing okay

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.10%. Comparing base (6887f75) to head (f33e278).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3837   +/-   ##
=======================================
  Coverage   79.10%   79.10%           
=======================================
  Files         279      279           
  Lines       12524    12524           
  Branches     2782     2782           
=======================================
  Hits         9907     9907           
  Misses       2617     2617           
Flag Coverage Δ
backend 79.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cstns cstns merged commit 71bb4dd into main May 8, 2024
14 checks passed
@cstns cstns deleted the 3789-dashboard-buton-in-immersive-view-is-always-available branch May 8, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend For any issues that require work in the frontend/UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard button in immersive view is always avaiable
2 participants