Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offboarding surveys #3853

Merged
merged 8 commits into from
May 14, 2024
Merged

Offboarding surveys #3853

merged 8 commits into from
May 14, 2024

Conversation

cstns
Copy link
Contributor

@cstns cstns commented May 14, 2024

Description

Adds offboarding options for platform admins.
Redirects offboarding users to a pre-defined url if set.

Related Issue(s)

#3825

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • [] Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@cstns cstns requested a review from knolleary May 14, 2024 12:41
@cstns cstns self-assigned this May 14, 2024
@cstns cstns added area:frontend For any issues that require work in the frontend/UI area:api Work on the platform API and removed deploy:pr labels May 14, 2024
@cstns
Copy link
Contributor Author

cstns commented May 14, 2024

Not sure if documentation needs updating

@cstns
Copy link
Contributor Author

cstns commented May 14, 2024

#3849 should address an e2e test when implemented.

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.22%. Comparing base (c1c6c18) to head (a0a5a73).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3853   +/-   ##
=======================================
  Coverage   79.22%   79.22%           
=======================================
  Files         281      281           
  Lines       12660    12660           
  Branches     2813     2813           
=======================================
  Hits        10030    10030           
  Misses       2630     2630           
Flag Coverage Δ
backend 79.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knolleary
Copy link
Member

@cstns Can we disable the failing test in this branch until the linked issue is fixed when we can re-enable it?

@cstns
Copy link
Contributor Author

cstns commented May 14, 2024

I thought I did, my bad

@knolleary
Copy link
Member

Happy for this to merge once the tests are all green.

@knolleary knolleary linked an issue May 14, 2024 that may be closed by this pull request
@knolleary knolleary mentioned this pull request May 14, 2024
@cstns cstns merged commit 470c42e into main May 14, 2024
13 checks passed
@cstns cstns deleted the 3825-offboarding-surveys branch May 14, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api Work on the platform API area:frontend For any issues that require work in the frontend/UI deploy:pr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offboarding Surveys
2 participants