Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tile-select option sizing #3861

Merged
merged 4 commits into from
May 16, 2024
Merged

Fix tile-select option sizing #3861

merged 4 commits into from
May 16, 2024

Conversation

knolleary
Copy link
Member

Whilst working on some improvements around changing team type, I notice the layout of the tile-selection-options was not aligning the vertical sizes.

image

On investigation, I found #3249 had wrapped the tile-selection-option in a div in order to get ff-tooltip working on the option. The wrapping div is then getting the right vertical size, but the option doesn't grow to fill it.

On further digging into why the div was added, it was done to get the tooltip working. The reason it wasn't working was a disabled tile-selection-option sets pointer-events:none, so the hover state is never triggered to show the tooltip.

This PR removes the wrapping div and modifies the css to remove the need to use pointer-events: none in the disabled state.

End result:

image

@knolleary knolleary requested a review from joepavitt May 15, 2024 15:49
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.22%. Comparing base (d99d46c) to head (62220c9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3861   +/-   ##
=======================================
  Coverage   79.22%   79.22%           
=======================================
  Files         281      281           
  Lines       12660    12660           
  Branches     2813     2813           
=======================================
  Hits        10030    10030           
  Misses       2630     2630           
Flag Coverage Δ
backend 79.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knolleary
Copy link
Member Author

knolleary commented May 16, 2024

Added a small change to allow the Team Type select to use full width, whilst keeping the form its reduced width.

Given we have 3 types in production,optimising to have them in a single row rather than split makes for a nicer layout.

image

@joepavitt
Copy link
Contributor

Agree with the change of widht for the tiles, but it looks very odd center-align, moved to left aligned instead:

Screenshot 2024-05-16 at 14 04 43

Copy link
Contributor

@joepavitt joepavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved subject to final tests passing

@knolleary
Copy link
Member Author

Agree with the change of widht for the tiles, but it looks very odd center-align, moved to left aligned instead:

I specifically didn't do that as all of our other forms (create app/instance etc) are center-aligned and constrained width. So was trying to keep some consistency with those - whilst allowing the type selection to 'expand' outwards.

But if you're happy with these changes, then no worries.

@joepavitt
Copy link
Contributor

But if you're happy with these changes, then no worries.

We have inconsistency in a lot of places with this, want to re-work forms in the near future, so might as well make the improvement here

@knolleary knolleary merged commit f4ac3cc into main May 16, 2024
13 checks passed
@knolleary knolleary deleted the fix-tile-select-layout branch May 16, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants