-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tile-select option sizing #3861
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3861 +/- ##
=======================================
Coverage 79.22% 79.22%
=======================================
Files 281 281
Lines 12660 12660
Branches 2813 2813
=======================================
Hits 10030 10030
Misses 2630 2630
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved subject to final tests passing
I specifically didn't do that as all of our other forms (create app/instance etc) are center-aligned and constrained width. So was trying to keep some consistency with those - whilst allowing the type selection to 'expand' outwards. But if you're happy with these changes, then no worries. |
We have inconsistency in a lot of places with this, want to re-work forms in the near future, so might as well make the improvement here |
Whilst working on some improvements around changing team type, I notice the layout of the tile-selection-options was not aligning the vertical sizes.
On investigation, I found #3249 had wrapped the
tile-selection-option
in a div in order to getff-tooltip
working on the option. The wrapping div is then getting the right vertical size, but the option doesn't grow to fill it.On further digging into why the div was added, it was done to get the tooltip working. The reason it wasn't working was a disabled tile-selection-option sets
pointer-events:none
, so the hover state is never triggered to show the tooltip.This PR removes the wrapping div and modifies the css to remove the need to use
pointer-events: none
in the disabled state.End result: