-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend for Uploading a Snapshot #3869
Conversation
includes missing UI parts for application.device.snapshot.exported
adds gap setting to CSS - this is in keep with actions slot on table search bar
includes improvements to brittle tests that could only be ran once and only in sequence.
@joepavitt Please review but do not merge until part 1 (Backend API #3868 is merged) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3869 +/- ##
=======================================
Coverage 79.26% 79.26%
=======================================
Files 281 281
Lines 12720 12720
Branches 2837 2837
=======================================
Hits 10082 10082
Misses 2638 2638
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Resolved in swap upload and create buttons on both empty-state and search toolbar 2e296a6 |
@joepavitt backend part is now merged (I have updated this PR too) so you can merge upon approval. Ta. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved subject to final tests passing, which they have done previously
Task 2 of 3 (part of #3628)
Description
Adds UI parts for Uploading a Snapshot
Details
snapshots:import
rolegap
between the buttons in the empty state actions slot (in line with the SCSSgap
setting for the table search actions slot)frontend/src/components/dialogs/SnapshotImportDialog.vue
isSnapshot
inforge/routes/api/snapshot.js
NOTE
E2E tests added
Related Issue(s)
Closes #3866
Story: #3628
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label