Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard role uses should get team summary view on api #3878

Merged
merged 1 commit into from
May 17, 2024

Conversation

knolleary
Copy link
Member

Part of https://github.com/FlowFuse/security/issues/89

A user with dashboard role doesn't need to see the full team api response. This PR resticts the response to the minimal summary needed for the UI to operate.

@knolleary knolleary requested a review from hardillb May 16, 2024 19:55
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.26%. Comparing base (c63326a) to head (69fec02).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3878   +/-   ##
=======================================
  Coverage   79.26%   79.26%           
=======================================
  Files         281      281           
  Lines       12720    12723    +3     
  Branches     2837     2838    +1     
=======================================
+ Hits        10082    10085    +3     
  Misses       2638     2638           
Flag Coverage Δ
backend 79.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hardillb hardillb merged commit 05a4c0d into main May 17, 2024
10 checks passed
@hardillb hardillb deleted the sec89-team-dashboard-view branch May 17, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants