Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flowfuse.com to the list of places allowed to load images from #3924

Merged
merged 1 commit into from
May 24, 2024

Conversation

hardillb
Copy link
Contributor

Description

This is CSP update to remove one more warning and get closer to enforcing, not just reporting.

The sign-up page on FF Cloud loads image from the website.

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

This is CSP update to remove one more warning and get closer to enforcing, not just reporting.
@hardillb hardillb self-assigned this May 24, 2024
@hardillb hardillb requested a review from knolleary May 24, 2024 10:38
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.28%. Comparing base (78ee033) to head (9c68ae2).
Report is 21 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3924   +/-   ##
=======================================
  Coverage   79.28%   79.28%           
=======================================
  Files         281      281           
  Lines       12755    12755           
  Branches     2844     2844           
=======================================
  Hits        10113    10113           
  Misses       2642     2642           
Flag Coverage Δ
backend 79.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knolleary
Copy link
Member

Approved, although this is ff cloud specific, so Ideally would be passed in via the config, rather than hardcoded.

@knolleary knolleary merged commit 45b1a1c into main May 24, 2024
10 checks passed
@knolleary knolleary deleted the hardillb-patch-1 branch May 24, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants