Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instance creation form getting stuck without a team after refresh #3945

Conversation

cstns
Copy link
Contributor

@cstns cstns commented May 28, 2024

Description

Extended the loading screen state to include the time it takes to load the teams.

The issue was caused by a combination of factors:

  • we are passing the team from the createInstance.vue page down to the InstanceForm
  • there is no persistent state for teams in local storage and each full page refresh needs to call all API endpoints again
  • creation form also loads teams

There is a short moment after the page re-loads and the team call is not finalized but the InstanceForm gets mounted with a null team prop and fails it's created method's api calls due to the team being null.

Related Issue(s)

part of #3884
closes #3934

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@cstns cstns self-assigned this May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.28%. Comparing base (d319e0d) to head (7163e5d).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3945   +/-   ##
=======================================
  Coverage   79.28%   79.28%           
=======================================
  Files         281      281           
  Lines       12755    12755           
  Branches     2844     2844           
=======================================
  Hits        10113    10113           
  Misses       2642     2642           
Flag Coverage Δ
backend 79.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cstns cstns requested a review from joepavitt May 29, 2024 07:40
@joepavitt joepavitt merged commit 1df27ef into main May 29, 2024
13 checks passed
@joepavitt joepavitt deleted the 3934-refresh-the-page-while-creating-an-aplication-does-not-load-teams-correctly branch May 29, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refreshing the page while creating an application instance does not load the team correctly
2 participants