Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter application instance creation page to resemble a standalone page #3947

Merged
merged 6 commits into from
May 29, 2024

Conversation

cstns
Copy link
Contributor

@cstns cstns commented May 28, 2024

Description

  • General styling made to the Application instance creation page.
  • Extracted common application instance non-representational functionality into separate mixin which will also allow to move entire state in the vuex store later on.
  • added an additional slot to the SectionNavigationHeader which allows replacing the existing breadcrumbs, required because of the custom format of the breadcrumbs of the create instance page

Related Issue(s)

closes #3933

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@cstns cstns marked this pull request as draft May 28, 2024 14:26
@cstns cstns changed the title diff Alter application instance creation page to resemble a standalone page May 28, 2024
…cation-does-not-load-teams-correctly' into 3933-alter-application-instance-creation-page
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.28%. Comparing base (7163e5d) to head (3df957a).

Additional details and impacted files
@@                                                Coverage Diff                                                @@
##           3934-refresh-the-page-while-creating-an-aplication-does-not-load-teams-correctly    #3947   +/-   ##
=================================================================================================================
  Coverage                                                                             79.28%   79.28%           
=================================================================================================================
  Files                                                                                   281      281           
  Lines                                                                                 12755    12755           
  Branches                                                                               2844     2844           
=================================================================================================================
  Hits                                                                                  10113    10113           
  Misses                                                                                 2642     2642           
Flag Coverage Δ
backend 79.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…-not-load-teams-correctly' into 3933-alter-application-instance-creation-page
cstns added 2 commits May 28, 2024 18:16
… createInstance page to resemble a standalone page
…creation-page' into 3933-alter-application-instance-creation-page
@cstns cstns requested a review from joepavitt May 29, 2024 07:46
@cstns cstns marked this pull request as ready for review May 29, 2024 07:46
@cstns cstns self-assigned this May 29, 2024
Base automatically changed from 3934-refresh-the-page-while-creating-an-aplication-does-not-load-teams-correctly to main May 29, 2024 08:01
@joepavitt joepavitt merged commit 23a7ac6 into main May 29, 2024
15 checks passed
@joepavitt joepavitt deleted the 3933-alter-application-instance-creation-page branch May 29, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alter the Application Instance creation page feel more like a standalone page
2 participants