Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure node red version in app device snapshot #3948

Merged
merged 3 commits into from
May 29, 2024

Conversation

Steve-Mcl
Copy link
Contributor

closes #3941

Description

Ensures the snapshot delivered via device/live includes a node-red version in the modules list

Adds test

  Device API
    Edit device details
      assign to application
        ✔ snapshot uploaded without node-red dependency is always delivered to a device with the node-red:version

Updates test

Device API
    Edit device details
      assign to application
        ✔ old `@flowforge/nr-project-nodes` dependency is replaced with @flowfuse dependency in an existing snapshot

Related Issue(s)

3941

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl Steve-Mcl requested a review from knolleary May 28, 2024 14:33
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.40%. Comparing base (c202138) to head (233cbda).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3948      +/-   ##
==========================================
+ Coverage   79.28%   79.40%   +0.11%     
==========================================
  Files         281      281              
  Lines       12755    12760       +5     
  Branches     2844     2845       +1     
==========================================
+ Hits        10113    10132      +19     
+ Misses       2642     2628      -14     
Flag Coverage Δ
backend 79.40% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knolleary knolleary merged commit 8bd6071 into main May 29, 2024
10 checks passed
@knolleary knolleary deleted the 3941-ensure-node-red-version-in-snapshot branch May 29, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Device Agent doesn't start after snapshot upload
2 participants