Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert billing_cycle_anchor change to fix coupons #3952

Merged
merged 2 commits into from
May 29, 2024
Merged

Conversation

knolleary
Copy link
Member

Fixes #3950 - reverting the billing_cycle_anchor change as I don't see any other practical way to support both that and coupons.

@knolleary knolleary requested a review from Steve-Mcl May 29, 2024 08:55
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.40%. Comparing base (8bd6071) to head (b4d2e4e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3952   +/-   ##
=======================================
  Coverage   79.40%   79.40%           
=======================================
  Files         281      281           
  Lines       12760    12752    -8     
  Branches     2845     2844    -1     
=======================================
- Hits        10132    10126    -6     
+ Misses       2628     2626    -2     
Flag Coverage Δ
backend 79.40% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not pulled/tested locally but I have confirmed this reverts back to state of play prior to #3748

@knolleary knolleary merged commit 571484a into main May 29, 2024
13 checks passed
@knolleary knolleary deleted the 3950_fix_coupons branch May 29, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot apply coupons on checkout when billing_anchor_date set
2 participants