Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relabel stack to node red version #3954

Merged
merged 7 commits into from
May 29, 2024
Merged

Relabel stack to node red version #3954

merged 7 commits into from
May 29, 2024

Conversation

cstns
Copy link
Contributor

@cstns cstns commented May 29, 2024 •
edited
Loading

Description

Updated ui to reflect new nomenclature for stacks for non-admin users.

Related Issue(s)

closes #3914
part of #3884

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@cstns cstns requested a review from joepavitt May 29, 2024 10:10
@codecov Codecov
Copy link

codecov bot commented May 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.40%. Comparing base (8bd6071) to head (028f4a7).
Report is 7 commits behind head on main.

❗ Current head 028f4a7 differs from pull request most recent head 414b12a

Please upload reports for the commit 414b12a to get more accurate results.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3954   +/-   ##
=======================================
  Coverage   79.40%   79.40%           
=======================================
  Files         281      281           
  Lines       12760    12760           
  Branches     2845     2845           
=======================================
  Hits        10132    10132           
  Misses       2628     2628
Flag Coverage Δ
backend 79.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cstns
Copy link
Contributor Author

cstns commented May 29, 2024

Not being a native English speaker some of the finer touches might have eluded me, so an additional check would be more than welcomed!

With the change in nomenclature some of the existing messages would also need touch-ups. Ex:

                        There is a new version of the current Node-RED Version available.
                        Updating the Node-RED Version will restart the instance.

@cstns
Copy link
Contributor Author

cstns commented May 29, 2024

Updated to

There is a new version of Node-RED available.
Updating the Node-RED Version will restart the instance.

As per @joepavitt 's recommendation

joepavitt
joepavitt reviewed May 29, 2024
View reviewed changes
Copy link
Contributor

@joepavitt joepavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about some code included, have queries - all good otherwise

joepavitt
joepavitt reviewed May 29, 2024
View reviewed changes
frontend/src/pages/team/createApplication.vue Outdated
Comment on lines 15 to 36
<template #header>
<ff-page-header title="Applications">
<template #context>
Let's get your new Node-RED application setup in no time.
</template>
</ff-page-header>
</template>
<ff-loading v-if="loading" message="Creating Application..." />
<InstanceForm
v-else
:instance="projectDetails"
:has-header="false"
:applications="applications"
:applicationSelection="applicationCreated"
:team="team"
:applicationFieldsLocked="applicationCreated"
:applicationFieldsVisible="true"
:billing-enabled="!!features.billing"
:flow-blueprints-enabled="!!features.flowBlueprints"
:submit-errors="errors"
@on-submit="handleFormSubmit"
/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be in here? Looks related to another PR for refreshing the Applications view?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must have sliped in from another task I was doing in parallel. Reverting

@cstns cstns enabled auto-merge May 29, 2024 11:44
@cstns cstns requested a review from joepavitt May 29, 2024 11:44
@cstns cstns merged commit 88225a7 into main May 29, 2024
12 checks passed
@cstns cstns deleted the 3914-relabel-stack-to-node-red-version branch May 29, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepavitt joepavitt joepavitt approved these changes

Assignees
No one assigned
Labels
deploy:pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Relabelling "Stack" to "Node-RED Version"
2 participants
@cstns @joepavitt