Hide deprecated env vars in the UI #3967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steve-Mcl
approved these changes
May 31, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3967 +/- ##
=======================================
Coverage 79.02% 79.02%
=======================================
Files 282 282
Lines 12839 12839
Branches 2863 2863
=======================================
Hits 10146 10146
Misses 2693 2693
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This hides the long-deprecated env vars in the UI as they should not be used today and we should not publicise them.
The way the
FF_env vars are injected, we have no way to selectively stop injecting them for new instances. We could just remove them (they have been marked deprecated for a long time) - but always nervous of breaking user's flows that have been happily running without needing to change.Removing them in the UI removes the noise and will prevent further accidental adoption.