Remove use of html option in Dialog when only used for newlines #3979
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
Dialog
service allows content to be provided as eithertext
orhtml
. Use of thehtml
option brings additional risk when including component names as that can lead to XSS vulnerabilities.This PR does three things:
text
content to include newlines - which are then automatically rendered properly in the dialoghtml
option over totext
where that were purely done to have newlines in the contentcanBeCanceled
option is also available when using the dialog service rather than via the component directly