Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of html option in Dialog when only used for newlines #3979

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

knolleary
Copy link
Member

Description

The Dialog service allows content to be provided as either text or html. Use of the html option brings additional risk when including component names as that can lead to XSS vulnerabilities.

This PR does three things:

  1. Allows the text content to include newlines - which are then automatically rendered properly in the dialog
  2. Moves all uses of the html option over to text where that were purely done to have newlines in the content
  3. Ensures the recently added canBeCanceled option is also available when using the dialog service rather than via the component directly

@knolleary knolleary requested a review from cstns June 4, 2024 09:16
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.02%. Comparing base (3d7af2a) to head (7deefe0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3979   +/-   ##
=======================================
  Coverage   79.02%   79.02%           
=======================================
  Files         282      282           
  Lines       12839    12839           
  Branches     2863     2863           
=======================================
  Hits        10146    10146           
  Misses       2693     2693           
Flag Coverage Δ
backend 79.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knolleary knolleary merged commit 560f800 into main Jun 5, 2024
12 of 13 checks passed
@knolleary knolleary deleted the sanitize-names branch June 5, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants