Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not send a slack notification on pre-staging termination #4001

Merged
merged 8 commits into from
Jun 10, 2024

Conversation

ppawlowski
Copy link
Contributor

@ppawlowski ppawlowski commented Jun 10, 2024

Description

This pull request fixes a problem when Slack notification about pre-staging environment spin-up is sent on the environment termination run.
Additionally, it fixes the job status icon in the message.

Related Issue(s)

#3998

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@ppawlowski ppawlowski marked this pull request as ready for review June 10, 2024 10:49
@ppawlowski ppawlowski requested a review from hardillb June 10, 2024 10:49
@hardillb hardillb merged commit 599d735 into main Jun 10, 2024
15 checks passed
@hardillb hardillb deleted the fix-notify-slack-branch-deploy branch June 10, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants