Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs Updated Local Install File HTTPS #4006

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

gdziuba
Copy link
Contributor

@gdziuba gdziuba commented Jun 10, 2024

Description

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@gdziuba gdziuba self-assigned this Jun 10, 2024
@gdziuba gdziuba requested a review from ZJvandeWeg June 10, 2024 14:05
@gdziuba gdziuba marked this pull request as ready for review June 10, 2024 14:08
@knolleary
Copy link
Member

Can you include a screenshot to show how this renders? I'm generally 👎🏻 on included hardcoded html styling like this, but it's hard to judge just from the raw html.

@gdziuba
Copy link
Contributor Author

gdziuba commented Jun 10, 2024

@knolleary

That makes sense. I was looking for it to stand out a little better.

image

@gdziuba
Copy link
Contributor Author

gdziuba commented Jun 10, 2024

Let me know if you want me to go a different route.

@knolleary knolleary enabled auto-merge June 11, 2024 08:54
@knolleary knolleary merged commit e89b683 into main Jun 11, 2024
13 checks passed
@knolleary knolleary deleted the gdziuba--docs-update-local-with-https branch June 11, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants