Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky time test #4021

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Fix flaky time test #4021

merged 2 commits into from
Jun 13, 2024

Conversation

Steve-Mcl
Copy link
Contributor

closes #3874

Description

Add 500ms grace to the relative time test to avoid a rare (but frequent enough to waste our time) test bug.

Related Issue(s)

#3874

Checklist

@Steve-Mcl Steve-Mcl requested a review from cstns June 13, 2024 09:01
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.58%. Comparing base (c11abf5) to head (980c113).
Report is 3 commits behind head on main.

Current head 980c113 differs from pull request most recent head 624fd34

Please upload reports for the commit 624fd34 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4021   +/-   ##
=======================================
  Coverage   78.57%   78.58%           
=======================================
  Files         284      284           
  Lines       12982    12979    -3     
  Branches     2891     2890    -1     
=======================================
- Hits        10201    10199    -2     
+ Misses       2781     2780    -1     
Flag Coverage Δ
backend 78.58% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Steve-Mcl Steve-Mcl enabled auto-merge June 13, 2024 10:29
@Steve-Mcl Steve-Mcl merged commit 5c8dc7e into main Jun 13, 2024
10 checks passed
@Steve-Mcl Steve-Mcl deleted the 3874-flakey-time-test branch June 13, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Random UI test fail - 1 second timing issue
2 participants