Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stack name if label not set #4033

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Use stack name if label not set #4033

merged 1 commit into from
Jun 14, 2024

Conversation

knolleary
Copy link
Member

Fixes #4032

Description

Ensures the label value passed to the <FormRow> options has a non-blank value - using the stack.nameifstack.label` hasn't been set.

@knolleary knolleary requested a review from cstns June 14, 2024 13:28
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.57%. Comparing base (f7a994a) to head (86fdc98).
Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4033      +/-   ##
==========================================
- Coverage   78.58%   78.57%   -0.01%     
==========================================
  Files         284      284              
  Lines       12979    12982       +3     
  Branches     2890     2891       +1     
==========================================
+ Hits        10199    10201       +2     
- Misses       2780     2781       +1     
Flag Coverage Δ
backend 78.57% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knolleary knolleary merged commit 2503798 into main Jun 14, 2024
10 checks passed
@knolleary knolleary deleted the 4032-default-stacklabel branch June 14, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Instance form: blank stack label
2 participants