Remove trickle down router props

[cstns]

Remove trickle down router props and cohesive way of using team, teamMembership and isVisitingAdmin

Description

Focusing mainly on teamMembership & team props which can be used directly from the permissionsMixin, or using accessing the account store directly where the permission mixin is not used.

The isVisitingAdmin computed prop has also been moved in the permissionsMixin

Related Issue(s)

none

Checklist

• I have read the contribution guidelines
• Suitable unit/system level tests have been added and they pass
• Documentation has been updated
  • Upgrade instructions
  • Configuration details
  • Concepts
• Changes flowforge.yml?
  • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
  • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

• Includes a DB migration? -> add the area:migration label

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.72%. Comparing base (c03fe4f) to head (3e542b2).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4076   +/-   ##
=======================================
  Coverage   78.72%   78.72%           
=======================================
  Files         284      284           
  Lines       13009    13009           
  Branches     2897     2897           
=======================================
  Hits        10241    10241           
  Misses       2768     2768           

Flag	Coverage Δ
backend	78.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[joepavitt]

I won't be able to review this today, so if someone else can step in, would appreciate it. My main point of concern is that if a user is logged in and viewing Team 1, and they directly navigate in the browser to a Team 2 page (e.g. viewing instances) that the new view reflects the correct team's data

[cstns]

I added two new tests to cover these specific scenarios

[joepavitt]

You're missing an opportunity for the permissionsMixin in pages/application/Overview.vue

[Steve-Mcl]

@joepavitt I went through this line by line with Serban . We found 1 left over prop and fixed that.

did a full review on pre-staging, tested all pages touched (with dev tools console open) and direct url access to alt teams etc.

I am happy to approve but will not merge as you may see something i dont

[joepavitt]

@Steve-Mcl thanks Steve, just left my own comments on this too

[Steve-Mcl]

all good from my pov.