Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable immersive editor for Node-RED 4.0.2+ and Launcher 2.6.0+ #4096

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

knolleary
Copy link
Member

Part of #3800

Having verified the immersive editor is now working in production for the about-to-ship launcher version and Node-RED 4.0.2, this is the final step to update the editor button to direct to the right place if the conditions are met.

Technically, it will work with nr-launcher 2.5.2-2f3c495-202407020855.0 or later, but to keep things clean, am pinning it to tomorrow's release version.

@knolleary knolleary requested a review from cstns July 3, 2024 14:03
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.75%. Comparing base (2ee732c) to head (581bc29).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4096   +/-   ##
=======================================
  Coverage   78.75%   78.75%           
=======================================
  Files         285      285           
  Lines       13031    13031           
  Branches     2902     2902           
=======================================
  Hits        10263    10263           
  Misses       2768     2768           
Flag Coverage Δ
backend 78.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knolleary knolleary merged commit 3013f61 into main Jul 3, 2024
10 checks passed
@knolleary knolleary deleted the enable-immersive-editor branch July 3, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants