Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding email formatting #4110

Merged
merged 3 commits into from
Jul 5, 2024
Merged

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Jul 4, 2024

Description

  • Adding the concept of email layouts
  • starting with a default template that mimics inbound marketing templates
  • outbound emails sent by the FF app will use these layouts

Related Issue(s)

closes #4039

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@cstns cstns self-assigned this Jul 4, 2024
@cstns cstns marked this pull request as draft July 4, 2024 14:48
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.75%. Comparing base (f8ced67) to head (ae355bd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4110   +/-   ##
=======================================
  Coverage   78.75%   78.75%           
=======================================
  Files         285      286    +1     
  Lines       13045    13048    +3     
  Branches     2907     2907           
=======================================
+ Hits        10273    10276    +3     
  Misses       2772     2772           
Flag Coverage Δ
backend 78.75% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cstns cstns requested a review from joepavitt July 5, 2024 08:51
@cstns cstns marked this pull request as ready for review July 5, 2024 08:51
@joepavitt joepavitt merged commit 3cca0bf into main Jul 5, 2024
16 checks passed
@joepavitt joepavitt deleted the 4039_onboarding-email-formatting branch July 5, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve onboarding e-mail formatting
2 participants