Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Change the way how Create pre-staging environment workflow is triggered #4130

Merged
merged 19 commits into from
Jul 8, 2024
Merged

ci: Change the way how Create pre-staging environment workflow is triggered #4130

merged 19 commits into from
Jul 8, 2024

Conversation

ppawlowski
Copy link
Contributor

@ppawlowski ppawlowski commented Jul 8, 2024 •
edited
Loading

Description

This pull request removes the need for a PR labelled with a deploy:pr label.
Instead:

  • changed files are verified by on.pull_request.paths-ignore
  • The user, who triggered the pipeline, is validated by the dedicated validate-user job

Related Issue(s)

#4070

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@ppawlowski ppawlowski marked this pull request as ready for review July 8, 2024 16:06
@ppawlowski ppawlowski requested a review from hardillb July 8, 2024 16:06
@hardillb hardillb merged commit 7492640 into main Jul 8, 2024
14 checks passed
@hardillb hardillb deleted the ci-pre-staging-trigger branch July 8, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardillb hardillb hardillb approved these changes

Assignees
No one assigned
Labels
deploy:pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ppawlowski @hardillb