Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to show mfa code instead of qrcode #4156

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Conversation

knolleary
Copy link
Member

Fixes #4118

Description

Adds option to show mfa secret for manual setup of authenticator app.

Link added below qrcode:

image

Clicking it toggles the view to:

image

with an option to toggle back.

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.76%. Comparing base (3dc892a) to head (f77e73e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4156   +/-   ##
=======================================
  Coverage   78.76%   78.76%           
=======================================
  Files         286      286           
  Lines       13053    13053           
  Branches     2910     2910           
=======================================
  Hits        10281    10281           
  Misses       2772     2772           
Flag Coverage Δ
backend 78.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joepavitt joepavitt merged commit 58c386a into main Jul 11, 2024
14 checks passed
@joepavitt joepavitt deleted the 4118-add-mfa-code branch July 11, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2FA QR Code should show manual code too
2 participants