carry on application search params to followup pages #4170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to the applicationDevices & applicationInstances routes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4170 +/- ##
=======================================
Coverage 78.62% 78.62%
=======================================
Files 286 286
Lines 13097 13097
Branches 2926 2926
=======================================
Hits 10298 10298
Misses 2799 2799
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…-instances-page' into 4167_carry-on-application-search-params
…-instances-page' into 4167_carry-on-application-search-params
|
@cstns you have requested a review here but it is still in draft. Can you clarify please? |
|
Did not finish e2e tests yet! should be done in a couple of hours |
…tion-search-params # Conflicts: # test/e2e/frontend/cypress/tests/applications/overview.spec.js
|
Ready for review! |
Steve-Mcl
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
carry the query string from the application search to instances/devices page
Related Issue(s)
closes #4167
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel