Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bulk intermittent e2e tests #4309

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Conversation

Steve-Mcl
Copy link
Contributor

Description

Fix intermittent e2e test fails on bulk ops.

Based on the captured logs, it seems to be always after selecting ff-check items. As though the "click" of an ff-check is somewhat async. Example:
image

Changes:

  • Add some preliminary array length checks to aid with debugging when the test fails
  • Add short 30ms delay AFTER checking checkboxes (handle async element)
  • Add additional interlocks (like dialog shown, delete button enabled) etc that should cause cy to wait for elements

I did manage to get the e2e test to fail locally (took about 10 runs) but after these changes it appears to be stable 🤞

Related Issue(s)

No issue, just random, intermittent test fails.

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl Steve-Mcl requested a review from joepavitt August 1, 2024 15:39
@Steve-Mcl Steve-Mcl added the task A piece of work that isn't necessarily tied to a specific Epic or Story. label Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.19%. Comparing base (c547148) to head (70d2c8d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4309   +/-   ##
=======================================
  Coverage   78.19%   78.19%           
=======================================
  Files         292      292           
  Lines       13440    13440           
  Branches     3007     3007           
=======================================
  Hits        10510    10510           
  Misses       2930     2930           
Flag Coverage Δ
backend 78.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Steve-Mcl Steve-Mcl requested review from cstns and removed request for joepavitt August 2, 2024 08:25
@cstns cstns merged commit 19f6fe1 into main Aug 2, 2024
14 checks passed
@cstns cstns deleted the fix-bulk-intermittant-e2e-tests branch August 2, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task A piece of work that isn't necessarily tied to a specific Epic or Story.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants