Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dynamically registered permissions #4320

Merged
merged 6 commits into from
Aug 7, 2024

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Aug 5, 2024

Description

Removes dynamically registered permissions and registered them statically to be made available to the front-end on buildtime

Related Issue(s)

#4061

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.15%. Comparing base (4e0aa9a) to head (227dafb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4320      +/-   ##
==========================================
- Coverage   78.19%   78.15%   -0.04%     
==========================================
  Files         292      292              
  Lines       13458    13438      -20     
  Branches     3012     3012              
==========================================
- Hits        10523    10503      -20     
  Misses       2935     2935              
Flag Coverage Δ
backend 78.15% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cstns cstns requested a review from Steve-Mcl August 5, 2024 08:19
@cstns cstns self-assigned this Aug 5, 2024
@Steve-Mcl Steve-Mcl linked an issue Aug 7, 2024 that may be closed by this pull request
@Steve-Mcl
Copy link
Contributor

Happy to merge when tests go green

@Steve-Mcl
Copy link
Contributor

Actually, i wanna double check something before i merge. Dont merge just yet.

Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approved.

Wanted to physically re-check some areas (via pre-staging) to ensure access was unchanged - all good.

@Steve-Mcl Steve-Mcl merged commit 4899db5 into main Aug 7, 2024
14 checks passed
@Steve-Mcl Steve-Mcl deleted the centralize-ee-and-os-permissions branch August 7, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable needsPermission mixin for EE level permissions
2 participants