Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighting the update stack options when navigating to the instance update settings #4321

Merged
merged 6 commits into from
Aug 8, 2024

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Aug 5, 2024

Description

Added a new composable that can highlight elements on a page by center scrolling and adding an animation.

Clicking the update button on the instance overview now navigates and highlights the update stack options.

Related Issue(s)

closes #4153

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@cstns cstns self-assigned this Aug 5, 2024
@cstns
Copy link
Contributor Author

cstns commented Aug 5, 2024

went with the animate-bounce animation as it was predefined in tailwind and was the easiest to use

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.17%. Comparing base (552a608) to head (717bcff).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4321   +/-   ##
=======================================
  Coverage   78.17%   78.17%           
=======================================
  Files         292      292           
  Lines       13430    13430           
  Branches     3010     3010           
=======================================
  Hits        10499    10499           
  Misses       2931     2931           
Flag Coverage Δ
backend 78.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cstns cstns requested a review from joepavitt August 5, 2024 12:11
@knolleary
Copy link
Member

Can you attach a screen recording to show the result?

@cstns
Copy link
Contributor Author

cstns commented Aug 6, 2024

This is the animate-bounce with tailwind:

animate-bounce.mp4

this is with a custom implementation that I have stashed locally but didn't make the cut:

custom-pop-up.mp4

@joepavitt
Copy link
Contributor

Not a fan of the animations, too exaggerated, and doesn't really fit with the surrounding content well...

I'm open to a new animation on just the button, just to expand/contract the button itself a couple of times so that it's highlighted?

@cstns
Copy link
Contributor Author

cstns commented Aug 6, 2024

I'll come up with a couple of alternatives

@cstns
Copy link
Contributor Author

cstns commented Aug 6, 2024

Here's a subtle jiggle variant:

jiggle-highlight.mp4

@joepavitt joepavitt merged commit 068fc44 into main Aug 8, 2024
14 checks passed
@joepavitt joepavitt deleted the clearer-ux-path-for-updating-nr-version branch August 8, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clearer UX Path for Updating NR Version
3 participants