Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project access for Admins #4327

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Fix project access for Admins #4327

merged 2 commits into from
Aug 6, 2024

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented Aug 6, 2024

Description

Check for Team role doesn't work for Admin

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb requested a review from knolleary August 6, 2024 10:34
@hardillb hardillb self-assigned this Aug 6, 2024
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.19%. Comparing base (adc278c) to head (e74055b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4327   +/-   ##
=======================================
  Coverage   78.19%   78.19%           
=======================================
  Files         292      292           
  Lines       13458    13458           
  Branches     3012     3012           
=======================================
  Hits        10523    10523           
  Misses       2935     2935           
Flag Coverage Δ
backend 78.19% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knolleary knolleary merged commit 339a4b0 into main Aug 6, 2024
14 checks passed
@knolleary knolleary deleted the fix-npmrc-admin branch August 6, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants